Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GenTtbarCategorizer_cfi.py (moved to fillDescription) #30288

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Remove GenTtbarCategorizer_cfi.py (moved to fillDescription) #30288

merged 2 commits into from
Jun 26, 2020

Conversation

silviodonato
Copy link
Contributor

PR description:

After #30150, the default values of GenTtbarCategorizer are defined using fillDescriptions.
This PR removes the old GenTtbarCategorizer_cfi.py and uses the automatically generated categorizeGenTtbar_cfi
#30150 (comment)

PR validation:

runTheMatrix.py -l limited -t 4 --ibeos

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Jun 18, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30288/16234

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

PhysicsTools/NanoAOD
TopQuarkAnalysis/TopTools

@cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: ae7e6bb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24d299/7171/summary.html
CMSSW: CMSSW_11_2_X_2020-06-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24d299/7171/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778757
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@santocch
Copy link

+1

@silviodonato
Copy link
Contributor Author

Any objections @peruzzim ?

@silviodonato
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 4c6506a into cms-sw:master Jun 26, 2020
This was referenced Jun 27, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-available orp-approved pending-signatures tests-approved xpog-pending
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.
3 participants
@silviodonato @cmsbuild @santocch